feat (codespaces) - Added initial support for codespaces.#865
feat (codespaces) - Added initial support for codespaces.#865ShreyasJejurkar wants to merge 4 commits intoashmind:mainfrom
Conversation
|
Thanks for raising this! I'll take a look now. |
| Write-Host "Opening new window for initial wait" -ForegroundColor White | ||
| Start-Process powershell -ArgumentList "-File `"$PSScriptRoot/run/wait.ps1`"" | ||
|
|
||
| if ($IsWindows) { |
There was a problem hiding this comment.
Probably don't have to check, we can just require it to be pwsh on Windows as well, or get whatever is the current shell (should be some built-in constant somewhere, or worst case command line[0]).
There was a problem hiding this comment.
pwsh is only applicable for PowerShell-Core. The PowerShell that bundles with Windows does not executable pwsh. If we make pwsh here, then we need to make it mandatory for contributors install PowerShell-Core, which I don't think is needed, as things can work with legacy PowerShell as well on windows.
| FROM mcr.microsoft.com/vscode/devcontainers/dotnet:0-${VARIANT} | ||
|
|
||
| # [Choice] Node.js version: none, lts/*, 16, 14, 12, 10 | ||
| ARG NODE_VERSION="none" |
There was a problem hiding this comment.
Hmm, we do have a node version requirement (for WebApp).
There was a problem hiding this comment.
Not sure why NODE_VERSION="none" here, need to check. But we do have NPM installed in codespaces. Check screenshot.
| RC_SNIPPET_ALREADY_ADDED=${RC_SNIPPET_ALREADY_ADDED}\n\ | ||
| ZSH_ALREADY_INSTALLED=${ZSH_ALREADY_INSTALLED}" > "${MARKER_FILE}" | ||
|
|
||
| echo "Done!" |
There was a problem hiding this comment.
Hmm, can this script be a submodule or otherwise downloaded dynamically?
There was a problem hiding this comment.
it will be there in the repository for codespaces. It's added by codespaces itself, so not sure!
|
One question I got one error for one the project can't remember the name actually, that the projects require .NET SDK 3.1 but found installed .NET SDK 5.0.100 (as this is what global.json says). Do we need both SDK to be installed as part of building SharpLab!? (right now we are installing both 3.1 and 5 SDK in the codespaces machine). See this one. |
…to codespaces-support
1. Added extensions for C# and Vue development. 2. Added some most used omnisharp settings for better experiance! 3. Changed dockerfile to 5.0.
|
I ran
Tye dashboard. It seems like azurite and webapp-assets are failing because those are restarted several times! |
|
I checked the log for web assets, seems like mirrrorsharp error. |
|
Thanks for raising those. Azurite should be installed by the latest |
ahh, no worries. We can go slow based on priority. No problem at all! I will check azurite, and let you know about it! |
|
took latest from main.
|
2 participants
Running
bash sl.sh setupin terminal successfully built the entire repository.WIP